You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This doesn't implement the changes described in the issue regarding deprecating the Amazon RDS profile in favor of moving that out to a new package but it does allow for a path forward to re-enabling rejectUnauthorized.
The follow scenarios are now true:
Set rejectUnauthorized: false - never any server identity verification
Set rejectUnauthorized: true or not provided:
set verifyIdentity: true or not provided - run provided checkServerIdentity() or use default tls.checkServerIdentity() function
set verifyIdentity: false - checkServerIdentity set to no-op function
How was this tested?
I tested changes locally against a tls-enabled postgresql instance. I'm not sure of how to incorporate any unit or integration tests for this as there does not currently appear to be any. Any support here would be lovely.
while the code around this change in your active memory - could you also please help reviewing #2295 ? That would be a minor version bump as it adds checkServerIdentity option. I don't like the fact that we would have 2 similarly named flags ( one is flag, one is function with custom check logic ), but might still worth adding
@juanheyns@sidorares regarding this concern of similarly named "things" from #2376, would you like me to rename it? I think this is still important as without it by setting the verifyIdentity flag to false you become more vulnerable to MITM attacks. By overriding the checkServerIdentity function we could enforce server identity in a way that makes sense for us. This is my line of thinking at least, does it make sense?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue described by #2119 (comment) and partially resolves #2172.
This doesn't implement the changes described in the issue regarding deprecating the Amazon RDS profile in favor of moving that out to a new package but it does allow for a path forward to re-enabling
rejectUnauthorized.The follow scenarios are now true:
Set
rejectUnauthorized: false- never any server identity verificationSet
rejectUnauthorized: trueor not provided:set
verifyIdentity: trueor not provided - run providedcheckServerIdentity()or use defaulttls.checkServerIdentity()functionset
verifyIdentity: false-checkServerIdentityset to no-op functionHow was this tested?
I tested changes locally against a tls-enabled postgresql instance. I'm not sure of how to incorporate any unit or integration tests for this as there does not currently appear to be any. Any support here would be lovely.